Update LegacySolverWrapper to be compatible with the pyomo script
#3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmundt
approved these changes
Mar 18, 2024
mrmundt
reviewed
Mar 18, 2024
| @@ -48,7 +48,7 @@ def test_ipopt_config(self): | |||
| self.assertIsInstance(config.executable, ExecutableData) | |||
|
|
|||
| # Test custom initialization | |||
| solver = SolverFactory('ipopt_v2', executable='/path/to/exe') | |||
| solver = SolverFactory('ipopt', executable='/path/to/exe') | |||
There was a problem hiding this comment.
This would test the "old" interface, wouldn't it?
There was a problem hiding this comment.
Nope - this PR follows the documentation and leverages the fact that the new interface is registered with the new SolverFactory as ipopt. Previously, the solver interface was being double-registered with the new factory (as both ipopt and ipopt_v2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This updates the
LegacySolverWrapperto be compatible with thepyomoscript.Changes proposed in this PR:
_map_configto be called more than oncereport_timingoption actually report timing informationLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: